Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roc test --ignore-error flag #6623

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add roc test --ignore-error flag #6623

wants to merge 10 commits into from

Conversation

horriblename
Copy link
Contributor

closes #6622

adds new flag to allow tests to be run even if build errors occurred, like roc run

Anton-4
Anton-4 requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @horriblename, I just improved some names. Can you add a test that uses the ignore-build-errors flag?

@horriblename horriblename force-pushed the feat-test-ignore-error branch from 44fb83f to 233d009 Compare April 6, 2024 16:51
@horriblename horriblename marked this pull request as ready for review April 6, 2024 16:53
@horriblename horriblename requested a review from Anton-4 April 6, 2024 16:53
@horriblename horriblename force-pushed the feat-test-ignore-error branch from 233d009 to 9aab0ff Compare April 6, 2024 16:53
Anton-4
Anton-4 previously approved these changes Apr 6, 2024
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @horriblename!

@horriblename horriblename force-pushed the feat-test-ignore-error branch from 4d1be22 to cc458c0 Compare April 9, 2024 17:07
@horriblename
Copy link
Contributor Author

horriblename commented Apr 9, 2024 •
edited
Loading

@Anton-4 ci checks failed earlier as some commits are "partially verified", can you sign it again?

@Anton-4
Copy link
Collaborator

Anton-4 commented Apr 9, 2024

@Anton-4 ci checks failed earlier as some commits are "partially verified", can you sign it again?

I believe there was also a failure in the wasm tests but I'll run CI again and we'll see what happens 😄

@Anton-4 Anton-4 self-assigned this Apr 10, 2024
ayazhafiz
ayazhafiz reviewed Apr 21, 2024
View reviewed changes
crates/cli/src/lib.rs Outdated Show resolved Hide resolved
@Anton-4 @ayazhafiz
clippy fix
4816127 
Co-authored-by: Ayaz <[email protected]>
Signed-off-by: Anton-4 <[email protected]>
@github-actions GitHub Actions
Copy link

Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked Closed are not deleted, so no matter what, the PR will still be right here in the repo. You can always access it and reopen it anytime you like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayazhafiz ayazhafiz ayazhafiz left review comments

@Anton-4 Anton-4 Anton-4 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Anton-4 Anton-4

Labels
inactive for 30 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add roc test --ignore-errors flag
4 participants
@horriblename @Anton-4 @ayazhafiz @lukewilliamboswell